Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prod release #797

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Prod release #797

merged 2 commits into from
Nov 21, 2023

Commits on Nov 20, 2023

  1. Set CACHEOPS_DEGRADE_ON_FAILURE to True 

    This commit is a follow-up to Incident 152 (and 95).

Currently, the app fails with HTTP 5xx errors if the associated
Redis cache is unreachable or cannot be used.

This commit sets the `CACHEOPS_DEGRADE_ON_FAILURE` environment
variable to be `True`. This env var instructs django-cacheops
to wrap Redis calls in a try/except block and to handle
connection errors and timeout errors gracefully, by writing
a warning to the logs, rather than letting the relevant
exception propagate up the stack.

See:
    https://github.com/Suor/django-cacheops#setup
    https://github.com/Suor/django-cacheops/blob/master/cacheops/redis.py#L12-L22
    @snim2
    snim2 committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    24ec9c6 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #795 from nhsx/feature/app-degrades-gracefully-on-… 

    …redis-failure

Set CACHEOPS_DEGRADE_ON_FAILURE to True
    @snim2
    snim2 committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    b8a2fd5 View commit details
    Browse the repository at this point in the history