fix: convert by using HTML tag when it is not between spaces #2572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adhrinae
reviewed
Jun 27, 2022
| const { content } = parent; | ||
|
|
||
| const isFrontNodeEndWithSpace = | ||
| index === 0 || isEndWithSpace(content.child(index - 1).text ?? 'a'); |
There was a problem hiding this comment.
기본값으로 처리한 'a' 는 공백 문자를 넣으면 isEndWithSpace 혹은 isStartWithSpace 가 제대로 동작하지 않으니까 임의로 넣은 문자인가요?
There was a problem hiding this comment.
그러게요. 'a'가 뭘 나타내는건지 의미를 만들어 상수화 시켜야겠습니다.
There was a problem hiding this comment.
넵, 해당 문자 의미 만들어서 상수화 했습니다.
Comment on lines
215
to
217
| if (betweenSpace) { | ||
| delim = '**'; | ||
| } else { |
There was a problem hiding this comment.
delim 변수를 선언할 때 기본값을 정하고, 분기문은 한번만 둬도 되지 않을까요?
let delim = '**';
if (!betweenSpace) {
delim = entering ? '<strong>' : '</strong>';
}
jwlee1108
reviewed
Jun 27, 2022
| const { content } = parent; | ||
|
|
||
| const isFrontNodeEndWithSpace = | ||
| index === 0 || isEndWithSpace(content.child(index - 1).text ?? 'a'); |
There was a problem hiding this comment.
그러게요. 'a'가 뭘 나타내는건지 의미를 만들어 상수화 시켜야겠습니다.
| rawHTML: entering ? getOpenRawHTML(rawHTML) : getCloseRawHTML(rawHTML), | ||
| }; | ||
| }, | ||
|
|
||
| emph({ node }, { entering }) { | ||
| emph({ node }, { entering }, betweenSpace) { |
adhrinae
approved these changes
Jun 27, 2022
6 tasks
kshnurov
added a commit
to kshnurov/tui.editor
that referenced
this pull request
Sep 26, 2022
jajugoguma
pushed a commit
that referenced
this pull request
Feb 16, 2023
ahamelers
pushed a commit
to ahamelers/tui.editor
that referenced
this pull request
Aug 21, 2023
* wip: convert strong to tag when it is not between spaces * fix: convert strong to tag when it is not between spaces * fix: convertor that follows the same rule * test: add test for convertor * chore: apply code reviews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
fix #xxx[,#xxx], where "xxx" is the issue number)Description
**"text"**ais not parsed.Typing content in WYSIWYG
As-Is
To-Be
Thank you for your contribution to TOAST UI product. 🎉 😘 ✨