Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the access to the array entry if not existing #2500

Merged
merged 2 commits into from
Sep 15, 2024
Merged

Fix the access to the array entry if not existing #2500

merged 2 commits into from
Sep 15, 2024

Conversation

christianlupus
Copy link
Collaborator

Topic and Scope

Closes #2487

Concerns/issues

none

Formal requirements

There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.

  • I did check that the app can still be opened and does not throw any browser logs
  • I created tests for newly added PHP code (check this if no PHP changes were made)
  • I updated the OpenAPI specs and added an entry to the API changelog (check if API was not modified)
  • I notified the matrix channel if I introduced an API change

Christian Wolf added 2 commits September 15, 2024 22:46
Fix the access to the array entry if not existing
a68bdf6 
Signed-off-by: Christian Wolf <git@christianwolf.email>
Update Changelog
a3199df 
Signed-off-by: Christian Wolf <git@christianwolf.email>
@christianlupus christianlupus marked this pull request as ready for review September 15, 2024 20:51
@christianlupus
Copy link
Collaborator Author

/approve

@github-actions GitHub Actions
Copy link

Test Results

   12 files    584 suites   1m 36s ⏱️
  575 tests   575 ✅ 0 💤 0 ❌
2 300 runs  2 299 ✅ 1 💤 0 ❌

Results for commit a3199df.

nextcloud-cookbook-bot
nextcloud-cookbook-bot approved these changes Sep 15, 2024
View reviewed changes
Copy link
Collaborator

@nextcloud-cookbook-bot nextcloud-cookbook-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approved by GitHub action on behalf of /approve

@christianlupus christianlupus merged commit de953ef into master Sep 15, 2024
31 checks passed
@christianlupus christianlupus deleted the fix/2487-access-id-only-if-existing branch September 15, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nextcloud-cookbook-bot nextcloud-cookbook-bot nextcloud-cookbook-bot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error Importing Recipe into Cookbook
2 participants
@christianlupus @nextcloud-cookbook-bot