Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes & updates to translation workflow #2557

Merged
merged 5 commits into from
Jun 3, 2021

Conversation

zstix
Copy link
Contributor

@zstix zstix commented Jun 1, 2021

Description

The workflow that checks the status of ongoing translation jobs (and makes a PR back into develop) was not picking up the most recent translation jobs. This was due to a few missed edge-cases. This PR should add some extra checks to ensure that the workflow will run successfully.

In addition, I spent a little effort cleaning up the comments and adding some better logging so we can more easily troubleshoot this workflow in the future.

Related Issue(s)

@gatsby-cloud
Copy link

gatsby-cloud bot commented Jun 1, 2021

Gatsby Cloud Build Report

docs-website-develop

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 37m

@x8a x8a added eng issues related to site functionality that requires engineering from_internal Identifies issues/PRs from Relics (except writers) labels Jun 2, 2021
@jmiraNR
Copy link
Collaborator

jmiraNR commented Jun 2, 2021

Hi @zstix, will/have the missed jobs been merged now? Thx

@zstix zstix merged commit b24a945 into develop Jun 3, 2021
@zstix zstix deleted the zstix/fix-translation-workflow branch June 3, 2021 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
eng issues related to site functionality that requires engineering from_internal Identifies issues/PRs from Relics (except writers)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Most recent completed job from translation vendor not PR'd back to the repo
4 participants