fix: also run blobs on ntl serve
#6183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardoboucas
previously approved these changes
Nov 17, 2023
src/commands/serve/serve.mts
Outdated
| @@ -71,7 +71,7 @@ const serve = async (options, command) => { | |||
| // Netlify Build are loaded. | |||
| await getInternalFunctionsDir({ base: site.root, ensureExists: true }) | |||
|
|
|||
| let settings = /** @type {import('../../utils/types.js').ServerSettings} */ ({}) | |||
| let settings = /** @type {import('../../utils/types.js').ServerSettings} */ {} | |||
There was a problem hiding this comment.
nit: Since you're touching this line, could you use the actual type instead of the JSDoc now that this is TypeScript?
src/commands/serve/serve.mts
Outdated
Comment on lines
75
to
76
| // @ts-expect-error TS(2571) FIXME: Type '{}' is not assignable to type 'ServerSettings'. | ||
| let settings: ServerSettings = {} |
There was a problem hiding this comment.
We can get rid of the ts-expect-error ugliness if you change L84 to return exit(1) (GitHub won't let me add a suggestion for that line).
Suggested change
| // @ts-expect-error TS(2571) FIXME: Type '{}' is not assignable to type 'ServerSettings'. | |
| let settings: ServerSettings = {} | |
| let settings: ServerSettings |
There was a problem hiding this comment.
smart! done in 2719485
eduardoboucas
previously approved these changes
Nov 20, 2023
eduardoboucas
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that we're only running blobs for
ntl dev, but not forntl serve. That's probably not right! This PR also starts the blob server duringntl serve.