fix: allow v2 functions to serve /favicon.ico #6145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Benchmark resultsComparing with 2547532
|
mraerino
previously approved these changes
Nov 10, 2023
|
Agree. I tried finding the original PR that added this, hoping there would be some context on this, but it goes way back to this commit from 2019: 9ffd514 |
This was referenced Dec 29, 2023
This was referenced Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have this weird edge case, where the functions server was catching all requests to /favicon.ico and prevented them from being served by functions. This PR fixes that, by moving the logic to a place where it only impacts routes that don't have a function assigned.