Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix decimal without typechecks #25

Merged
merged 4 commits into from
Oct 18, 2018
Merged

Fix decimal without typechecks #25

merged 4 commits into from
Oct 18, 2018

Conversation

jsdario
Copy link
Member

@jsdario jsdario commented Oct 18, 2018

Use single quotes and show different approach
Different approach
Update colorsys.js
Fixed for colors without 'red' or 'red/green' values

@jsdario jsdario changed the title Pull request for fix-decimal Fix decimal withoyt typechecks Oct 18, 2018
@jsdario jsdario changed the title Fix decimal withoyt typechecks Fix decimal without typechecks Oct 18, 2018
LucasGarci
LucasGarci approved these changes Oct 18, 2018
View reviewed changes
Copy link
Contributor

@LucasGarci LucasGarci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me parece awesome. He probado los cambios en node y funciona bien

@jsdario jsdario merged commit 4c4a0e6 into netbeast:master Oct 18, 2018
@jsdario jsdario mentioned this pull request Oct 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucasGarci LucasGarci LucasGarci approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsdario @LucasGarci