Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(msg): add truncate option to avoid hit-enter #32

Merged
merged 2 commits into from
Dec 7, 2020
Merged

feat(msg): add truncate option to avoid hit-enter #32

merged 2 commits into from
Dec 7, 2020

Conversation

iamcco
Copy link
Contributor

@iamcco iamcco commented Dec 5, 2020

Add json.truncateMessage to avoid hit-enter. default false

Can't even edit when fetch schema error by now.

@chemzqm
Copy link
Member

chemzqm commented Dec 7, 2020 •
edited
Loading

You can use logger to log the error or not show it, instead of truncate the warning which could be unreadable.

@iamcco
Copy link
Contributor Author

iamcco commented Dec 7, 2020

I have change to output channel

@chemzqm chemzqm merged commit 5759680 into neoclide:master Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iamcco @chemzqm