Skip to content

Commit

Permalink
Unmark files as executable that can't actually be executed. (pythonGH…
Browse files Browse the repository at this point in the history
…-15353)

There are plenty of legitimate scripts in the tree that begin with a
`#!`, but also a few that seem to be marked executable by mistake.

Found them with this command -- it gets executable files known to Git,
filters to the ones that don't start with a `#!`, and then unmarks
them as executable:

    $ git ls-files --stage \
      | perl -lane 'print $F[3] if (!/^100644/)' \
      | while read f; do
          head -c2 "$f" | grep -qxF '#!' \
          || chmod a-x "$f"; \
        done

Looking at the list by hand confirms that we didn't sweep up any
files that should have the executable bit after all.  In particular

 * The `.psd` files are images from Photoshop.

 * The `.bat` files sure look like things that can be run.
   But we have lots of other `.bat` files, and they don't have
   this bit set, so it must not be needed for them.



Automerge-Triggered-By: @benjaminp
  • Loading branch information
gnprice authored and miss-islington committed Aug 21, 2019
1 parent 5b95a15 commit 9ece4a5
Show file tree
Hide file tree
Showing 16 changed files with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions .azure-pipelines/posix-deps-apt.sh
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#!/bin/sh
apt-get update

apt-get -yq install \
Expand Down
Empty file modified Doc/c-api/buffer.rst
100755 → 100644
Empty file.
Empty file modified Include/cpython/abstract.h
100755 → 100644
Empty file.
Empty file modified Lib/idlelib/idle.bat
100755 → 100644
Empty file.
Empty file modified Lib/test/test_buffer.py
100755 → 100644
Empty file.
Empty file modified Lib/test/test_dataclasses.py
100755 → 100644
Empty file.
Empty file modified Lib/test/test_importlib/test_abc.py
100755 → 100644
Empty file.
Empty file modified Lib/turtledemo/two_canvases.py
100755 → 100644
Empty file.
Empty file modified Mac/Resources/iconsrc/PythonCompiled.psd
100755 → 100644
Empty file.
Empty file modified Mac/Resources/iconsrc/PythonIcon.psd
100755 → 100644
Empty file.
Empty file modified Mac/Resources/iconsrc/PythonSource.psd
100755 → 100644
Empty file.
Empty file.
Empty file modified Modules/_decimal/tests/runall.bat
100755 → 100644
Empty file.
Empty file modified Modules/_testcapimodule.c
100755 → 100644
Empty file.
Empty file modified Modules/socketmodule.c
100755 → 100644
Empty file.
Empty file modified Modules/socketmodule.h
100755 → 100644
Empty file.

0 comments on commit 9ece4a5

Please sign in to comment.