feat: add a TypeScript declaration file for graphql-hooks-memcache #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackdclark
force-pushed
the
feat/type-declarations-memcache
branch
from
60efa7d
to
1280370
Compare
Joezo
reviewed
Mar 14, 2019
| @@ -5,6 +5,7 @@ | |||
| "main": "lib/graphql-hooks-memcache.js", | |||
| "module": "es/graphql-hooks-memcache.js", | |||
| "unpkg": "dist/graphql-hooks-memcache.min.js", | |||
| "types": "index.d.ts", | |||
There was a problem hiding this comment.
I think you'll have to add this file to the files array on line 14
There was a problem hiding this comment.
Ah yes good spot, I did this in #135.
jackdclark
force-pushed
the
feat/type-declarations-memcache
branch
from
1280370
to
e955ff8
Compare
bmullan91
approved these changes
Mar 14, 2019
| }): MemCache | ||
|
|
||
| interface MemCache { | ||
| get(keyObject: object): object |
There was a problem hiding this comment.
Technically keyObject could be any, but graphql-hooks gives it an object 😆
Joezo
approved these changes
Mar 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a https://www.typescriptlang.org/docs/handbook/declaration-files/introduction.html for
graphql-hooks-memcachethat will be published to npm, so that the package works well with TypeScript.Related issues
#91
Checklist