Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Slack Node): Add option to hide workflow link on message update #10927

Conversation

Joffcom
Copy link
Member

@Joffcom Joffcom commented Sep 23, 2024

Summary

Adds the Include Link to Workflow option to Message > Update without this when updating a message without the link we were adding it again with no way for the user to control it.

Related Linear tickets, Github issues, and Community forum posts

#9803
https://linear.app/n8n/issue/NODE-1423/slack-allow-removing-automated-with-n8n-footer-in-update-operation

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Sep 23, 2024
Copy link
Contributor

@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

Copy link

cypress bot commented Sep 25, 2024

n8n    Run #7026

Run Properties:  status check passed Passed #7026  •  git commit 36700bf7e5: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 Joffcom 🗃️ e2e/*
Project n8n
Branch Review node-1423-slack-allow-removing-automated-with-n8n-footer-in-update
Run status status check passed Passed #7026
Run duration 04m 23s
Commit git commit 36700bf7e5: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 Joffcom 🗃️ e2e/*
Committer Jonathan Bennetts
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 430
View all changes introduced in this branch ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@ShireenMissi ShireenMissi merged commit 422c946 into master Sep 25, 2024
33 checks passed
@ShireenMissi ShireenMissi deleted the node-1423-slack-allow-removing-automated-with-n8n-footer-in-update branch September 25, 2024 07:48
@github-actions github-actions bot mentioned this pull request Sep 25, 2024
@janober
Copy link
Member

janober commented Sep 25, 2024

Got released with n8n@1.61.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants