Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(editor): Use virtual scrolling in RunDataJson.vue #10838

Merged
merged 7 commits into from
Sep 19, 2024
Merged

perf(editor): Use virtual scrolling in RunDataJson.vue #10838

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8d7fb65
Use virtual scrolling in RunDataJson.vue
RicardoE105 Sep 16, 2024
2ecba8d
update snapshot to account for virtual scrolling
RicardoE105 Sep 16, 2024
0484b39
Merge branch 'master' into ado-2598-enable-virtual-scrolling-in-node-…
RicardoE105 Sep 18, 2024
9255eab
apply feedback
RicardoE105 Sep 18, 2024
f6a0a11
remove unused import
RicardoE105 Sep 18, 2024
153d154
add padding-bottom back
RicardoE105 Sep 18, 2024
69b50eb
update tests
RicardoE105 Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
update tests
  • Loading branch information
@RicardoE105
RicardoE105 committed Sep 18, 2024
commit 69b50eb27d194b195c7617dc0c4e39cf0ac823da
28 changes: 16 additions & 12 deletions packages/editor-ui/src/components/__tests__/RunDataJson.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,22 @@ import { createTestingPinia } from '@pinia/testing';
import { screen, cleanup } from '@testing-library/vue';
import RunDataJson from '@/components/RunDataJson.vue';
import { createComponentRenderer } from '@/__tests__/render';
import { useElementSize } from '@vueuse/core'; // Import the composable to mock

vi.mock('@vueuse/core', async () => {
// eslint-disable-next-line @typescript-eslint/consistent-type-imports
const originalModule = await vi.importActual<typeof import('@vueuse/core')>('@vueuse/core');

return {
...originalModule, // Keep all original exports
useElementSize: vi.fn(), // Mock useElementSize
};
});

(useElementSize as jest.Mock).mockReturnValue({
height: 500, // Mocked height value
width: 300, // Mocked width value
});

const renderComponent = createComponentRenderer(RunDataJson, {
props: {
Expand Down Expand Up @@ -34,18 +50,6 @@ const renderComponent = createComponentRenderer(RunDataJson, {
disabled: false,
},
},
global: {
mocks: {
$locale: {
baseText() {
return '';
},
},
$store: {
getters: {},
},
},
},
});

describe('RunDataJson.vue', () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/editor-ui/src/components/__tests__/__snapshots__/RunDataJson.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ exports[`RunDataJson.vue > renders json values properly 1`] = `
>
<div
class="vjs-tree-list"
style="height: 400px;"
style="height: 500px;"
>
<div
class="vjs-tree-list-holder"
Expand Down
Loading