fix(Read/Write Files from Disk Node): Better error handling when file name missing (no-changelog) #10463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
ShireenMissi
force-pushed
the
node-1524-readwrite-files-from-disk-node-better-error-handling-when-file-name
branch
from
b994826
to
7c4a504
Compare
Joffcom
approved these changes
Aug 19, 2024
|
✅ All Cypress E2E specs passed |
|
Test summaryRun details
Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
||||||||||||||||||||||||||
ShireenMissi
changed the title
ShireenMissi
deleted the
node-1524-readwrite-files-from-disk-node-better-error-handling-when-file-name
branch
MiloradFilipovic
added a commit
that referenced
this pull request
Aug 19, 2024
* master: fix(editor): Fix edge button background color in dark mode in new canvas (no-changelog) (#10475) feat(editor): Add old execution status rendering in new canvas (no-changelog) (#10473) feat(editor): Update cursor behaviour in new canvas (no-changelog) (#10472) fix(editor): Add missing control button events to new canvas (no-changelog) (#10471) fix: Show input names when node has multiple inputs (#10434) fix(editor): Adjust default zoom level in new canvas (no-changelog) (#10469) fix(Read/Write Files from Disk Node): Better error handling when file name missing (no-changelog) (#10463) fix: Remove unimplemented Postgres credentials options (#10461) fix(Invoice Ninja Node): Fix payment types (#10462)
|
Got released with |
riascho
pushed a commit
that referenced
this pull request
Aug 26, 2024
… name missing (no-changelog) (#10463)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR shows better error handling when file name missing instead of just throwing an internal error
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-1524/readwrite-files-from-disk-node-better-error-handling-when-file-name
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)