refactor(editor): Add types to ndv event bus (no-changelog) #10451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
alexgrozav
approved these changes
Aug 16, 2024
|
Test summaryRun details
Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
||||||||||||||||||||||||||
|
✅ All Cypress E2E specs passed |
MiloradFilipovic
added a commit
that referenced
this pull request
Aug 19, 2024
* master: refactor(editor): Add types to ndv event bus (no-changelog) (#10451) fix: Better errors in Switch, If and Filter nodes (#10457) fix(Google Sheets Node): Update to returnAllMatches option (#10440) fix(Google Sheets Node): Better error when column to match on is empty (#10442) fix(OpenAI Node): Throw node operations error in case of openAi client error (#10448) feat(editor): Update canvas control buttons design and behaviour in new canvas (no-changelog) (#10435) fix(editor): Fix flaky mapping tests (#10453)
|
Got released with |
riascho
pushed a commit
that referenced
this pull request
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add types to ndv event bus
Related Linear tickets, Github issues, and Community forum posts
CAT-32
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)