refactor(core): Move queue recovery to scaling service (no-changelog) #10368
Conversation
n8n-assistant
bot
added
core
| if (storedIds.length === 0) { | ||
| this.logger.debug('[ScalingService] Completed queue recovery check, no dangling executions'); | ||
| return waitMs; | ||
| } |
There was a problem hiding this comment.
getInProgressExecutionIds seems to get executions with status new and running, but not waiting. If there are only waiting executions in DB, they are not checked as we short-circuit here. Is that intentional?
There was a problem hiding this comment.
Queue recovery reconciles Redis state with DB state, so if Redis knows an execution not to be in any state in the Bull queue anymore, then the DB status is stale and needs to be overridden to crashed.
In your example, if a DB has zero new or running executions, e.g. all waiting, then those waiting executions have not made it to the Bull queue yet, so there is nothing to reconcile. The requirements in the original story mentioned only new and running.
Please let me know if this is what you meant.
|
|
|
Test summaryRun details
Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
||||||||||||||||||||||||||
|
✅ All Cypress E2E specs passed |
* master: (98 commits) feat(core): Allow overriding npm registry for community packages (#10325) feat(core): Upgrade DB drivers (no-changelog) (#10370) fix(editor): Fix bug causing workflow debugging to not work in new canvas (no-changelog) (#10384) fix: Fix issue with some errors not being handled correctly (no-changelog) (#10371) fix(core): Filter out prototype and constructor lookups in expressions (#10382) fix(editor): Connect up new project viewer role to the FE (#9913) refactor(core): Move queue recovery to scaling service (no-changelog) (#10368) fix(core): Account for owner when filtering by project ID in `GET /workflows` in Public API (#10379) fix(editor): Fix rendering of SVG icons in public chat on iOS (#10381) fix: Require mfa code to disable mfa (#10345) ci: Disable turbo cache when running tests for coverage collection (no-changelog) (#10380) refactor(editor): Add typed event bus (no-changelog) (#10367) refactor(core): Remove unused constants in Redis channels (no-changelog) (#10369) fix(editor): Revert change that hid swagger docs in the ui (#10350) fix(Okta Node): Add missing codex file (no-changelog) (#10372) fix(core): Fix worker shutdown errors when active executions (#10353) refactor(core): Rename ActiveWebhooks to LiveWebhooks (no-changelog) (#10355) fix(n8n Form Trigger Node): Fix issue preventing v1 node from working (#10364) feat(editor): Upgrade markdown-it to address AIKIDO-2024-10034 (no-changelog) (#10358) ci: Upgrade axios to address CVE-2024-39338 (no-changelog) (#10365) ... # Conflicts: # packages/design-system/package.json
|
Got released with |
Queue recovery belongs in the scaling service, which did not exist when queue recovery was created.