Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(n8n Form Trigger Node): Remove custom attribution option (no-changelog) #10229

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

michael-radency
Copy link
Contributor

Summary

Custom Attribution Option removed as to be addressed in farther customization update

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-1505/form-trigger-improvements-p1

@michael-radency michael-radency added n8n team Authored by the n8n team node/issue Issue with a node labels Jul 29, 2024
@michael-radency michael-radency changed the title fix(n8n Form Trigger Node): Removed custom attribution option (no-changelog) fix(n8n Form Trigger Node): Remove custom attribution option (no-changelog) Jul 29, 2024
Copy link
Contributor

@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Copy link

cypress bot commented Jul 29, 2024

Passing run #6182 ↗︎

0 389 0 0 Flakiness 0

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 michael-radency 🗃️ e2e/*
Project: n8n Commit: 70f3669484
Status: Passed Duration: 04:14 💡
Started: Jul 29, 2024 2:51 PM Ended: Jul 29, 2024 2:55 PM

Review all test suite changes for PR #10229 ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@michael-radency michael-radency merged commit e5dfd7f into master Jul 29, 2024
27 of 28 checks passed
@michael-radency michael-radency deleted the form-trigger-descope-custom-attribution branch July 29, 2024 14:56
MiloradFilipovic added a commit that referenced this pull request Jul 30, 2024
* master:
  docs: Update login url for OpenAI node (no-changelog) (#10222)
  fix(LinkedIn Node): Fix issue with some characters cutting off posts early (#10185)
  fix(Google BigQuery Node): Send timeoutMs in query, pagination support (#10205)
  feat(core): Show Public API key value only once (no-changelog) (#10126)
  refactor(core): Display stack trace in error reporter (no-changelog) (#10225)
  fix(core): Fix missing successful items on continueErrorOutput with multiple outputs (#10218)
  fix(n8n Form Trigger Node): Remove custom attribution option (no-changelog) (#10229)
  feat(n8n Form Trigger Node): Improvements (#10092)
  refactor(core): Port path, host, port, listen_address and protocol config (no-changelog) (#10223)
  docs: Update add options text (no-changelog) (#10049)
  fix(Postgres Node): Option to treat query parameters enclosed in single quotas as text (#10214)
  refactor(core): Decouple server started event from internal hooks (no-changelog) (#10221)
  feat(Shopify Node): Update Shopify API version (#10155)
  fix(editor): Defer `User saved credentials` telemetry event for OAuth credentials (#10215)
  fix(editor): Fix parameter input glitch when there was an error loading remote options (#10209)
@janober
Copy link
Member

janober commented Jul 31, 2024

Got released with n8n@1.53.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/issue Issue with a node Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants