fix(core): Require mfa code to disable mfa #10345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
alexgrozav
requested changes
Aug 12, 2024
tomi
added a commit
that referenced
this pull request
Aug 12, 2024
Continuation of #10345. Require MFA code when changing email address if MFA is enabled.
4 tasks
alexgrozav
previously approved these changes
Aug 12, 2024
|
Test summaryRun details
Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
||||||||||||||||||||||||||
|
✅ All Cypress E2E specs passed |
Base automatically changed from
fix-require-mfa-code-for-password-change
to
master
August 12, 2024 14:08
tomi
force-pushed
the
fix-require-mfa-code-for-disabling-mfa
branch
from
c4cd440
to
d59b08d
Compare
netroy
reviewed
Aug 12, 2024
4 tasks
tomi
force-pushed
the
fix-require-mfa-code-for-disabling-mfa
branch
from
d59b08d
to
df13a4f
Compare
tomi
force-pushed
the
fix-require-mfa-code-for-disabling-mfa
branch
from
df13a4f
to
d8f198c
Compare
|
Rebased on top of #10367. Once that is merged we can merge this one as well |
Continuation of #10341 Also enables rate limiting for the `/mfa/disable` endpoint. For the FE: - adds a typed event emitter - a mechanism to use Modal event emitter to provide data back from the modal
tomi
force-pushed
the
fix-require-mfa-code-for-disabling-mfa
branch
from
d8f198c
to
d92431f
Compare
netroy
approved these changes
Aug 13, 2024
|
✅ All Cypress E2E specs passed |
tomi
added a commit
that referenced
this pull request
Aug 14, 2024
Continuation of #10345. Require MFA code when changing email address if MFA is enabled.
MiloradFilipovic
added a commit
that referenced
this pull request
Aug 14, 2024
* master: (98 commits) feat(core): Allow overriding npm registry for community packages (#10325) feat(core): Upgrade DB drivers (no-changelog) (#10370) fix(editor): Fix bug causing workflow debugging to not work in new canvas (no-changelog) (#10384) fix: Fix issue with some errors not being handled correctly (no-changelog) (#10371) fix(core): Filter out prototype and constructor lookups in expressions (#10382) fix(editor): Connect up new project viewer role to the FE (#9913) refactor(core): Move queue recovery to scaling service (no-changelog) (#10368) fix(core): Account for owner when filtering by project ID in `GET /workflows` in Public API (#10379) fix(editor): Fix rendering of SVG icons in public chat on iOS (#10381) fix: Require mfa code to disable mfa (#10345) ci: Disable turbo cache when running tests for coverage collection (no-changelog) (#10380) refactor(editor): Add typed event bus (no-changelog) (#10367) refactor(core): Remove unused constants in Redis channels (no-changelog) (#10369) fix(editor): Revert change that hid swagger docs in the ui (#10350) fix(Okta Node): Add missing codex file (no-changelog) (#10372) fix(core): Fix worker shutdown errors when active executions (#10353) refactor(core): Rename ActiveWebhooks to LiveWebhooks (no-changelog) (#10355) fix(n8n Form Trigger Node): Fix issue preventing v1 node from working (#10364) feat(editor): Upgrade markdown-it to address AIKIDO-2024-10034 (no-changelog) (#10358) ci: Upgrade axios to address CVE-2024-39338 (no-changelog) (#10365) ... # Conflicts: # packages/design-system/package.json
Merged
netroy
changed the title
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Continuation of #10341
Also enables rate limiting for the
/mfa/disableendpoint.For the FE:
Kapture.2024-08-09.at.18.20.05.mp4
Related Linear tickets, Github issues, and Community forum posts
SEC-67
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)