Release 2.0 stable

[felixge]

Hi guys,

do you guys have any objections against cutting a 2.0 stable release at some point? Do we have some APIs that we need decisions on?

It would be really nice if npm install mysql would start doing the right thing : ).

cc @dresende @ifsnow @kai-koch

[marcuswestin]

+1
—
Sent from Mailbox for iPad

On Fri, Jun 28, 2013 at 12:37 AM, Felix Geisendörfer
notifications@github.com wrote:

Hi guys,
do you guys have any objections against cutting a 2.0 stable release at some point? Do we have some APIs that we need decisions on?
It would be really nice if npm install mysql would start doing the right thing : ).

cc @dresende @ifsnow @kai-koch

Reply to this email directly or view it on GitHub:
#526

[dnalborczyk]

Hey Felix,

a final version would be pretty nice to have - you could also spin up (some) betas prior.

It would be really nice though to have 'prepared statements' working during the alpha/beta phase; in case the API has to change ...

just my 2 cents :)
Daniel

PS: Is there already a branch you/or somebody started working on? Maybe I can help ...

[felixge]

It would be really nice though to have 'prepared statements' working during the alpha/beta phase; in case the API has to change ...

Well, the funding status of this is a bit unclear again, so I don't know when / if I'll have time to work on it. We can always release 3.0 if we have to break the API for prepared statements (I dont' think we'll have to, they'll be a simple addition).

Anyway, I did get the very basics going over here: https://github.com/felixge/node-mysql/tree/prepare - if somebody wants to pick it up - go for it. It's mainly all the different types that need implementing.

[ifsnow]

I think that it would be good if #505 was included.
But, The more reviews are necessary.

I will check more. After that, try to merge.

There are no objections about 2.0 stable release.

[tellnes]

I also think there should be a stable 2.0 soon, but some issues should be fixed first. Maybe we should create a milestone?

[kai-koch]

👍

[dresende]

I agree with @tellnes , a milestone would be nice. Maybe we could make a sprint and try to close bugs on Poll.

[tellnes]

Created a milestone and added a few issues to it.

[felixge]

@tellnes <3 thanks.

Everybody else: Should we add anything else to this list?

[tellnes]

@felixge and everybody else: Probably yes. I just added a few issues at the top of the issue tracker.

[dresende]

Looks good for now :)

[tomasikp]

please take a look at #539. There is a potential breaking change proposed which would be good to be included prior to cutting a stable release.

[sidorares]

Just found this discussion while searching for pool idle disconnect options ( #505 ). I don't think it fits 2.0 release (it adds new api) but I really want to see it in 2.1

[dresende]

Let's open a new issue when needed to discuss 2.1. 2.0 is done :)

[sidorares]

@dresende I'm planning to release more often if you don't mind, no need to have discussion for releases. On the other hand, let's have a rule of at least two 👍 on non-trivial pull request before merging

[dresende]

Yes, no need for a discussion for every release. I was just wanted to close the issue. Any other issues should be addressed in new ones :) I agree with at least 2 👍