updated EDM import that uses a CSV as a source for relevant EDMs #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Example EDMs csv: |
zarino
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
This works! (Once I remembered that I needed to mark the datasets as is_public, or log in, to see them.)
I wonder whether repeating "MP support for…" in the table on the area page is really required – although I can see why you’ve named the dataset that way. This is probably good enough to go for now, we can always rename the dataset, or whatever other improvement we come up with, later.
struan
force-pushed
the
603-update-edms
branch
2 times, most recently
from
2a3c8c1
to
e8bf7cc
Compare
Mostly the same code as the existing importer, only it uses a CSV to getg the list of EDMs to import so this can be updated without having to touch the code. Part of #603
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly the same code as the existing importer, only it uses a CSV to getg the list of EDMs to import so this can be updated without having to touch the code.
Part of #603