License Updates -- *** HUGE CHANGE *** #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m2e lifecycle-mapping is needed via plugin defined in parent so move it there instead. Add license txt file for maven loading licenses
preferrably should be preferably
emacarron
added a commit
that referenced
this pull request
Feb 5, 2015
License Updates -- *** HUGE CHANGE ***
|
Let's see how this works! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
**** PLEASE READ CAREFULLY. ALL JAVA FILES HAVE BEEN TOUCHED ****
Added apache license badge to project readme.
Move m2e execution filter to parent for cleaner approach.
Add license.txt based on current mybatis java file headers.
Updated license year in POM and the new license.txt
Corrected spelling mistake on ICLA.
The bulk of the change was to update the license headers on all pages. This additionally consisted of a fix with one misplaced license header. This touched all java files. The style of header is now javadoc rather than javascript. Generally only the year changed to include 2015. There were some changes in authors but minimal at best. There was also some minimal spacing changes. This took least approach to get this done. There is a chance I did not see any other duplicated headers like the one I fixed but certainly possible given this level of change.
The license is now driven by presence of the license.txt file in root of project. This is further setup in the parent on a separate pull request. Provided this is liked as a clean solution, I will address getting this into all other mybatis projects. This will activate on all builds so if that is unwanted, it is as simple as deleting the license.txt file now that this has been completed. Then in future years, the file can simply be put back in place. Generally this doesn't appear to slow the builds down very much.
Enjoy!