[TreeView] Use useDefaultProps instead of useThemeProps
#14772
+26
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
requested review from
siriwatknp
and removed request for
mnajdova
flaviendelangle
added
the
component: tree view
|
Deploy preview: https://deploy-preview-14772--material-ui-x.netlify.app/ |
|
@flaviendelangle I got this error, seems like there is a wrong usage of It comes from …
style: {
marginLeft: 'calc(var(--TreeView-indentMultiplier) * var(--TreeView-itemDepth))',
borderRadius: theme.shape.borderRadius,
- backgroundColor: alpha((theme.vars || theme).palette.primary.dark, 0.15)
+ backgroundColor: alpha(theme.palette.primary.dark, 0.15)
} |
siriwatknp
approved these changes
Sep 30, 2024
There was a problem hiding this comment.
It works with Pigment CSS https://github.com/siriwatknp/x-tree-view-pigment-css
There was a problem hiding this comment.
To note that we have mui/material-ui#43443 that advocates for removing this API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the new API introduced by the core team.
We need to bump
@mui/materialdeps to use5.16.0or above in order to support it, which makes this a breaking change.I'm opening this PR to check with the core if the approach is good before preparing the one for the pickers to merge it at the beginning of the alpha.