Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[l10n] Improve Czech (cs-CZ) locale #14732

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[l10n] Improve Czech (cs-CZ) locale #14732

wants to merge 1 commit into from

Conversation

JakubSveda
Copy link

@JakubSveda
words translated to czech
b55df53 
Signed-off-by: Jakub Švéda <77570677+JakubSveda@users.noreply.github.com>
@mui-bot
Copy link

mui-bot commented Sep 25, 2024

Localization writing tips ✍️

Seems you are updating localization 🌍 files.

Thank you for contributing to the localization! 🎉 To make your PR perfect, here is a list of elements to check: ✔️

  • Verify if the PR title respects the release format. Here are two examples (depending if you update or add a locale file)

    [l10n] Improve Swedish (sv-SE) locale
    [l10n] Add Danish (da-DK) locale

  • Update the documentation of supported locales by running pnpm l10n
  • Clean files with pnpm prettier.

Deploy preview: https://deploy-preview-14732--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against b55df53

@zannager zannager added component: data grid This is the name of the generic UI component, not the React module! l10n localization and removed component: data grid This is the name of the generic UI component, not the React module! labels Sep 26, 2024
@alexfauquette alexfauquette changed the title Words translated to czech [l10n] Improve Czech (cs-CZ) locale Sep 26, 2024
@alexfauquette alexfauquette added the component: pickers This is the name of the generic UI component, not the React module! label Sep 26, 2024
arthurbalduini
arthurbalduini reviewed Sep 27, 2024
View reviewed changes
packages/x-date-pickers/src/locales/csCZ.ts
@@ -78,24 +78,24 @@ const csCZPickers: Partial<PickersLocaleText<any>> = {
fieldYearPlaceholder: (params) => 'Y'.repeat(params.digitAmount),
fieldMonthPlaceholder: (params) => (params.contentType === 'letter' ? 'MMMM' : 'MM'),
fieldDayPlaceholder: () => 'DD',
// fieldWeekDayPlaceholder: params => params.contentType === 'letter' ? 'EEEE' : 'EE',
fieldWeekDayPlaceholder: params => params.contentType === 'letter' ? 'EEEE' : 'EE',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You must parenthesis, otherwise prettier will not be happy 😉

Suggested change
fieldWeekDayPlaceholder: params => params.contentType === 'letter' ? 'EEEE' : 'EE',
fieldWeekDayPlaceholder: (params) => (params.contentType === 'letter' ? 'EEEE' : 'EE'),

@arthurbalduini
Copy link
Member

Hello, thanks a lot for the contribution ! 🎉
Among the improvements of the translation values, you must also update the key count data on the localization json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arthurbalduini arthurbalduini arthurbalduini left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
component: pickers This is the name of the generic UI component, not the React module! l10n localization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JakubSveda @mui-bot @arthurbalduini @alexfauquette @zannager