[TreeView] Remove instance.getTreeItemIdAttribute
#14667
Conversation
flaviendelangle
added
the
component: tree view
|
Deploy preview: https://deploy-preview-14667--material-ui-x.netlify.app/ |
| @@ -23,8 +10,19 @@ export interface UseTreeViewIdParameters { | |||
|
|
|||
| export type UseTreeViewIdDefaultizedParameters = UseTreeViewIdParameters; | |||
|
|
|||
| export interface UseTreeViewIdState { | |||
| id: { | |||
There was a problem hiding this comment.
Quick question: any reason why we are nesting treeId? Is it to be able to identify the state related to a certain plugin more easily? Should we do the same for other plugin states?
There was a problem hiding this comment.
Is it to be able to identify the state related to a certain plugin more easily?
Yes, I took the habit to namespace everything in the state
Should we do the same for other plugin states?
Do we have some plugins where it is not the case?
There was a problem hiding this comment.
UseTreeViewFocusState and UseTreeViewLabelState do not follow this convention from what I see
There was a problem hiding this comment.
I think I fixed those in #14210 👼
But that's something I should definitely extract
Extracted from #14210
This is typically the type of instance methods that require us to re-render every item since it's used in the render of the item.
We need to make sure the id attribute of every item is up to date at all time, but with this PR we only have to listen to
treeIdin order to update the id attribute of the item.