[charts] Replace path with circle for perf improvement
#14518
Conversation
alexfauquette
commented
Sep 6, 2024
alexfauquette
commented
- I have followed (at least) the PR section of the contributing guide.
alexfauquette
added
performance
component: charts
|
Deploy preview: https://deploy-preview-14518--material-ui-x.netlify.app/ |
flaviendelangle
changed the title
path by circle for perf improvementpath with circle for perf improvement
CodSpeed Performance ReportMerging #14518 will not alter performanceComparing Summary
|
|
I was disturbed that codespeed did not reported positive impact. But it seems ok
|
We can change to a lower percentage, probably makes sense to make it like 3-5% |
| /** | ||
| * If `true` marks will render `<circle />` instead of `<path />` and drop theme override for faster rendering. | ||
| */ | ||
| markPerfUpdate?: boolean; |
There was a problem hiding this comment.
| markPerfUpdate?: boolean; | |
| usePerformantMarks?: boolean; |
There was a problem hiding this comment.
| markPerfUpdate?: boolean; | |
| improveMarkPerformance?: boolean; |
There was a problem hiding this comment.
markPerfUpdate sounds vague, "update" is a status, so it doesn't fully describe the action I think.
There was a problem hiding this comment.
What about experimentalMarkRendering To say it's planned to be the future default behavior in v8?
There was a problem hiding this comment.
Yeah, I think that would be great
|
To fix benchmarks #14573 |
