[fields] Improve useSplitFieldProps and make it public
#14514
Merged
+106
−128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
added
the
component: pickers
|
Deploy preview: https://deploy-preview-14514--material-ui-x.netlify.app/ |
flaviendelangle
force-pushed
the
useSplitFieldInternalAndForwardedProps
branch
from
40bb070
to
a5a6d79
Compare
flaviendelangle
changed the title
useSplitFieldInternalAndForwardedProps and make it publicuseSplitFieldInternalAndForwardedProps and make it public
LukasTy
approved these changes
Sep 11, 2024
Comment on lines
44
to
51
| export const useSplitFieldInternalAndForwardedProps = < | ||
| TValueType extends FieldValueType, | ||
| TProps extends { [key in InternalPropNames<TValueType>]?: any }, | ||
| >( | ||
| props: TProps, | ||
| valueType: TValueType, | ||
| ) => { | ||
| return React.useMemo(() => { |
There was a problem hiding this comment.
Awesome improvements (typing and memoization)! 💙 💯 🙌
packages/x-date-pickers/src/hooks/useSplitFieldInternalAndForwardedProps.ts
Outdated
Show resolved
Hide resolved
4 tasks
flaviendelangle
changed the title
useSplitFieldInternalAndForwardedProps and make it publicuseSplitFieldProps and make it public
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #14486
Closes #14515
Work
TInternalPropsgeneric (makes the whole DX a lot lighter)splitFieldInternalAndForwardedPropsinto a hook so that the computation does not re-occur when the component has a re-render that is not caused by a prop change (it has a lot of re-renders caused by state update insideuseField)@mui/x-date-pickers/hooks