[pickers] Improve onError JSDoc
#14492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
added
the
component: pickers
|
Deploy preview: https://deploy-preview-14492--material-ui-x.netlify.app/ |
flaviendelangle
changed the title
onError JSDoc
LukasTy
approved these changes
Sep 5, 2024
packages/x-date-pickers/src/internals/hooks/useField/useField.types.ts
Outdated
Show resolved
Hide resolved
packages/x-date-pickers/src/internals/hooks/useField/useField.types.ts
Outdated
Show resolved
Hide resolved
packages/x-date-pickers/src/internals/hooks/useField/useField.types.ts
Outdated
Show resolved
Hide resolved
flaviendelangle
force-pushed
the
onError
branch
from
15427ed
to
69c7142
Compare
4 tasks
This was referenced Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #14486
We have 3 places where the
onErrorprop is defined, and IMHO the one used for the doc generation is not the best one.I unified to 3 in this PR to avoid having massive doc generated file change in the main PR (where I move the 3 definition into a single place).
The current 3 formulation are the 3 last files on this PR if you want to compare them.