Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[l10n] Improve Turkish (tr-TR) locale #13996

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Conversation

bagcivan
Copy link
Contributor

Turkish translation deficiencies for data-grid completed.

@mui-bot
Copy link

mui-bot commented Jul 27, 2024

Localization writing tips ✍️

Seems you are updating localization 🌍 files.

Thank you for contributing to the localization! 🎉 To make your PR perfect, here is a list of elements to check: ✔️

  • Verify if the PR title respects the release format. Here are two examples (depending if you update or add a locale file)

    [l10n] Improve Swedish (sv-SE) locale
    [l10n] Add Danish (da-DK) locale

  • Update the documentation of supported locales by running pnpm l10n
  • Clean files with pnpm prettier.

Deploy preview: https://deploy-preview-13996--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against ec84189

@flaviendelangle flaviendelangle changed the title Turkish translation updates [l10n] Improve Turkish (trTR) locale (data grid) Jul 29, 2024
@flaviendelangle flaviendelangle added component: data grid This is the name of the generic UI component, not the React module! l10n localization labels Jul 29, 2024
Copy link
Contributor

@KenanYusuf KenanYusuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Teşekkürler @bagcivan

@KenanYusuf
Copy link
Contributor

@bagcivan something is up with the CI - please could you try syncing this branch with master? https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@bagcivan
Copy link
Contributor Author

bagcivan commented Jul 29, 2024

@bagcivan something is up with the CI - please could you try syncing this branch with master? https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@KenanYusuf i did the sync process with dropdown

@bagcivan bagcivan requested a review from KenanYusuf July 29, 2024 15:15
@KenanYusuf
Copy link
Contributor

@bagcivan I think you might have done it on master because it hasn't merged anything - try from this branch view https://github.com/bagcivan/mui-x/tree/turkish-translate

@LukasTy
Copy link
Member

LukasTy commented Jul 29, 2024

@KenanYusuf just mentioning that the problem with Netlify deployment failure is known (also happening on material-ui repo) and being looked into.

@LukasTy
Copy link
Member

LukasTy commented Jul 30, 2024

@KenanYusuf I've restarted the deployment on Netlify but the status on this PR will not update unless a new commit is pushed.
All the newly created PRs should be good regarding this Netlify building problem and for all previously created PRs we might need to trigger a new build with cache purging.
Screenshot 2024-07-30 at 14 58 56

It does not seem that there are other clear solutions. 🙈 🤷

The restarted build:
Screenshot 2024-07-30 at 15 11 02

I'm merging it.

@LukasTy LukasTy changed the title [l10n] Improve Turkish (trTR) locale (data grid) [l10n] Improve Turkish (tr-TR) locale Jul 30, 2024
@LukasTy LukasTy merged commit 0643f18 into mui:master Jul 30, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! l10n localization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants