[core] Test charts performance with codspeed
#13952
Conversation
JCQuintas
added
core
|
Deploy preview: https://deploy-preview-13952--material-ui-x.netlify.app/ |
CodSpeed Performance ReportCongrats! CodSpeed is installed 🎉
You will start to see performance impacts in the reports once the benchmarks are run from your default branch.
|
| push: | ||
| branches: | ||
| - 'master' | ||
| - 'next' | ||
| paths: | ||
| - 'packages/x-charts*/**' |
There was a problem hiding this comment.
We could change this to "release" instead, to update the base "bechmarks" release-by-release instead of every push to master
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
PR: out-of-date
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
PR: out-of-date
| export default defineConfig({ | ||
| plugins: [codspeedPlugin(), react()], | ||
| test: { | ||
| environment: 'jsdom', |
There was a problem hiding this comment.
Are you sure that jsdom is where you want to test performance? Imo, as an emulated test environment it has more chances of diverging from what users see in real-world cases.
There was a problem hiding this comment.
Yes, we took that into account. It is better than nothing right now. We want to know if the changes we introduce affect the rendering times by a significant % amount, not necessarily real user times.
Once the platform supports testing using browser/playwright we will definitely change to use that instead.
This is also "free" for us right now.
Initial testing of the charts performance using codspeed
Reports
You can see a live report example at: JCQuintas#4
Unchanged
Regressions/Improvements
Accepting regressions
Once there is a regression over our delimited threshold (currently 10%), we need to manually accept that in their UI.