Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tree view][docs] Fix scroll demos disorientation #13909

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Jul 20, 2024

I got confused playing with the demo of https://mui.com/x/react-tree-view/simple-tree-view/items/#imperative-api. I clicked on the button and got lost, it took me to click 2 more times on the button to understand this demo.

Before

Screen.Recording.2024-07-20.at.11.34.29.mov

After

Screen.Recording.2024-07-20.at.11.35.01.mov

Off-topic. @samuelsycamore I think this could be a small example of work / responsibility we could envision to structure to "Docs" team to grow around, meaning to be accountable for the end-to-end experience of the docs.

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! labels Jul 20, 2024
@mui-bot
Copy link

mui-bot commented Jul 20, 2024

Deploy preview: https://deploy-preview-13909--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 095e98b

Copy link
Member

@flaviendelangle flaviendelangle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👌 , I didn't know about "nearest"

@oliviertassinari oliviertassinari added the design This is about UI or UX design, please involve a designer label Jul 22, 2024
@oliviertassinari oliviertassinari merged commit 3e0c2fd into mui:master Jul 22, 2024
20 checks passed
@oliviertassinari oliviertassinari deleted the tree-view-scroll-ux branch July 22, 2024 12:07
DungTiger pushed a commit to DungTiger/mui-x that referenced this pull request Jul 23, 2024
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! design This is about UI or UX design, please involve a designer docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants