[fields] Do not apply digit editing when pressing Space (@flaviendelangle)
#13516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
bug 🐛
Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com>
Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com>
flaviendelangle
removed
the
needs cherry-pick
|
Deploy preview: https://deploy-preview-13516--material-ui-x.netlify.app/ |
LukasTy
approved these changes
Jun 17, 2024
| version "1.0.30001576" | ||
| resolved "https://registry.yarnpkg.com/caniuse-lite/-/caniuse-lite-1.0.30001576.tgz#893be772cf8ee6056d6c1e2d07df365b9ec0a5c4" | ||
| integrity sha512-ff5BdakGe2P3SQsMsiqmt1Lc8221NR1VzHj5jXN5vBny9A6fpze94HiVV/n7XRosOlsShJcvMv5mdnpjOGCEgg== | ||
| version "1.0.30001587" |
There was a problem hiding this comment.
I've manually installed a newer version that passed the build.
Installing the latest package would also fail the build. 🙈
This is not directly related to this PR, but it's just a side-effect of the caniuse-lite.
Building on the v6.x would have resulted in the same error and the need to bump the package.
|
Asked for a review from @flaviendelangle to have a final look and the "honour" to merge with with overriding checks (vale fails for some unknown reason 🤷 ) |
flaviendelangle
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #13510