[l10n] Improve Korean (ko-KR) locale #13452
Conversation
Localization writing tips ✍️Seems you are updating localization 🌍 files. Thank you for contributing to the localization! 🎉 To make your PR perfect, here is a list of elements to check: ✔️
Deploy preview: https://deploy-preview-13452--material-ui-x.netlify.app/ |
| @@ -45,7 +45,7 @@ const koKRPickers: Partial<PickersLocaleText<any>> = { | |||
| // Clock labels | |||
| clockLabelText: (view, time, adapter) => | |||
| `${views[view]} 선택하세요. ${time === null ? '시간을 선택하지 않았습니다.' : `현재 선택된 시간은 ${adapter.format(time, 'fullTime')}입니다.`}`, | |||
| hoursClockNumberText: (hours) => `${hours}시간`, | |||
| hoursClockNumberText: (hours) => `${hours}시`, | |||
There was a problem hiding this comment.
Are you sure about this change?
Given Google Translate the difference is as follows:
10 hours -> 10 o'clock, is it expected?
In English, we also didn't use o'clock, because it could be misinterpreted.
O'clock means—exactly that hour/time, but in this case, it might often not be the case as this is a label for only the hours section/part on the TimeClock or MultiSectionDigitalClock.
Can you confirm if the expectation in Korean is different than in English?
There was a problem hiding this comment.
I understand and appreciate your concerns regarding the use of "o'clock."
Just as "o'clock" in English signifies an exact time, specifically the top of the hour, the Korean equivalent "시" serves a similar yet slightly different role in time selection.
-
In English,
o'clock:- Precisely refers to a specific time. For example: "10
o'clock" means exactly 10:00 AM or 10:00 PM. - Implies that the user must select an exact hour.
- However, using
o'clockin a time selection tool might lead to the misconception that users cannot set minutes or seconds in addition to the hour.
- Precisely refers to a specific time. For example: "10
-
In Korean,
시:- Similarly refers to a specific time but is more flexible. For example: "10
시" can mean 10o'clock, but users naturally understand that they can also adjust the minutes and seconds. - For example, "10:03" in Korean is expressed as "10
시3분," which clearly indicates a specific time. - This allows users to easily understand and set hours, minutes, and seconds.
- Similarly refers to a specific time but is more flexible. For example: "10
Example of 10:03
-
In English:
- The expression "10
o'clockand 3 minutes" is not used. - Instead, we say "10:03 AM" or "10 oh three in the morning."
- The expression "10
-
In Korean:
- The expression "10
시3분" is commonly used. - This means exactly 10:03 AM.
- The expression "10
In this context, using "시" in the Korean UI is an effective way to provide users with a clear option to select a time within that hour range, thus minimizing confusion.
There was a problem hiding this comment.
Thank you for a detailed explanation! 🙏
It was a nice "language school day". 👍
LukasTy
added
l10n
| @@ -45,7 +45,7 @@ const koKRPickers: Partial<PickersLocaleText<any>> = { | |||
| // Clock labels | |||
| clockLabelText: (view, time, adapter) => | |||
| `${views[view]} 선택하세요. ${time === null ? '시간을 선택하지 않았습니다.' : `현재 선택된 시간은 ${adapter.format(time, 'fullTime')}입니다.`}`, | |||
| hoursClockNumberText: (hours) => `${hours}시간`, | |||
| hoursClockNumberText: (hours) => `${hours}시`, | |||
There was a problem hiding this comment.
Thank you for a detailed explanation! 🙏
It was a nice "language school day". 👍
The current translation for hoursClockNumberText is 'hh시간', which is incorrect and misleading in the context of time selection. This commit changes it to 'hh시', which is the correct and appropriate translation for selecting hours.