Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[l10n] Improve Danish (da-DK) locale #13375

Merged
merged 4 commits into from
Jun 17, 2024
Merged

[l10n] Improve Danish (da-DK) locale #13375

merged 4 commits into from
Jun 17, 2024

Conversation

jacrowland1
Copy link
Contributor

@jacrowland1 jacrowland1 commented Jun 5, 2024 •
edited
Loading

I've updated the Danish (da-DK) locale for the date pickers to add in the remaining missing translations

@mui-bot
Copy link

mui-bot commented Jun 5, 2024 •
edited
Loading

Localization writing tips ✍️

Seems you are updating localization 🌍 files.

Thank you for contributing to the localization! 🎉 To make your PR perfect, here is a list of elements to check: ✔️

  • Verify if the PR title respects the release format. Here are two examples (depending if you update or add a locale file)

    [l10n] Improve Swedish (sv-SE) locale
    [l10n] Add Danish (da-DK) locale

  • Update the documentation of supported locales by running pnpm l10n
  • Clean files with pnpm prettier.

Deploy preview: https://deploy-preview-13375--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 8420c51

@LukasTy
Copy link
Member

LukasTy commented Jun 5, 2024

@jacrowland1 Thank you for your contribution! 🙏
It looks like you have created the branch from the next branch [1, 2], which caused unnecessary changes.
Could you please rebase your branch on the latest upstream/master or create a new branch based on it and cherry-pick your changes? 🤔

@LukasTy LukasTy added l10n localization component: pickers This is the name of the generic UI component, not the React module! labels Jun 5, 2024
genepaul and others added 3 commits June 5, 2024 18:50
@genepaul @romgrk @jacrowland1
export GridAggregationParams for use with custom aggregators (mui#12822)
34f8f5e 
Signed-off-by: Gene Arch <genepaularch@gmail.com>
Co-authored-by: Rom Grk <romgrk.cc@gmail.com>
@jacrowland1
Added daDK translations to x-date-pickers
8689c06
@jacrowland1
l10n
1a7188b
@jacrowland1 jacrowland1 force-pushed the update-danish-date-pickers-locale branch from 101eef8 to 1a7188b Compare June 5, 2024 06:53
LukasTy
LukasTy approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the contribution! 🙏
Sorry, but I didn't see that you fixed the PR. 🙈
Adding a comment would have triggered a comment, at least with my notification settings. 😉

@LukasTy LukasTy merged commit 8ffdb01 into mui:master Jun 17, 2024
17 checks passed
@jacrowland1 jacrowland1 deleted the update-danish-date-pickers-locale branch June 20, 2024 23:56
This was referenced Jul 13, 2024
Open
Open
@alhabib5565 alhabib5565 mentioned this pull request Jul 14, 2024
Open
@KotoneZQ KotoneZQ mentioned this pull request Jul 18, 2024
Open
This was referenced Jul 20, 2024
Open
Open
@Carment14tham Carment14tham mentioned this pull request Jul 20, 2024
Open
DungTiger pushed a commit to DungTiger/mui-x that referenced this pull request Jul 23, 2024
@jacrowland1 @genepaul
@romgrk @DungTiger
[l10n] Improve Danish (da-DK) locale (mui#13375)
22e15f7 
Signed-off-by: Gene Arch <genepaularch@gmail.com>
Co-authored-by: Gene Arch <genepaularch@gmail.com>
Co-authored-by: Rom Grk <romgrk.cc@gmail.com>
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
@jacrowland1 @genepaul
@romgrk @thomasmoon
[l10n] Improve Danish (da-DK) locale (mui#13375)
b9b6e26 
Signed-off-by: Gene Arch <genepaularch@gmail.com>
Co-authored-by: Gene Arch <genepaularch@gmail.com>
Co-authored-by: Rom Grk <romgrk.cc@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasTy LukasTy LukasTy approved these changes

Assignees
No one assigned
Labels
component: pickers This is the name of the generic UI component, not the React module! l10n localization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jacrowland1 @mui-bot @LukasTy @genepaul