[core] Fix l10n script execution with arguments
#13297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasTy
commented
May 29, 2024
| "typescript:transpile:dev": "cross-env BABEL_ENV=development babel-node --extensions \".tsx,.ts,.js\" scripts/formattedTSDemos --watch", | ||
| "populate:demos": "cross-env BABEL_ENV=development babel-node --extensions \".tsx,.ts,.js\" scripts/populatePickersDemos" | ||
| "typescript:transpile:dev": "cross-env BABEL_ENV=development node scripts/formattedTSDemos --watch", | ||
| "populate:demos": "tsx scripts/populatePickersDemos" |
There was a problem hiding this comment.
node didn't work here, even though the file is js, but it loads other js file with an export usage.
|
Deploy preview: https://deploy-preview-13297--material-ui-x.netlify.app/ |
JCQuintas
reviewed
May 29, 2024
| @@ -15,8 +15,8 @@ | |||
| "create-playground": "cpy --cwd=scripts playground.template.tsx ../../pages/playground --rename=index.tsx", | |||
| "typescript": "tsc -p tsconfig.json", | |||
| "typescript:transpile": "cross-env BABEL_ENV=development node scripts/formattedTSDemos", | |||
| "typescript:transpile:dev": "cross-env BABEL_ENV=development babel-node --extensions \".tsx,.ts,.js\" scripts/formattedTSDemos --watch", | |||
| "populate:demos": "cross-env BABEL_ENV=development babel-node --extensions \".tsx,.ts,.js\" scripts/populatePickersDemos" | |||
| "typescript:transpile:dev": "cross-env BABEL_ENV=development node scripts/formattedTSDemos --watch", | |||
There was a problem hiding this comment.
Do we need BABEL_ENV=development if not using babel anymore? 🤔
There was a problem hiding this comment.
Left it here, because the file internally uses @babel/core 🤔
JCQuintas
approved these changes
May 29, 2024
DungTiger
pushed a commit
to DungTiger/mui-x
that referenced
this pull request
Jul 23, 2024
thomasmoon
pushed a commit
to thomasmoon/mui-x
that referenced
this pull request
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix https://github.com/mui/mui-x/actions/runs/9287240393
Follow up on #13251 (comment)
Replace a few other easy instances of
babel-nodeusages withnodeortsx.