Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[charts] Fix grid duplicated key #12208

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Conversation

alexfauquette
Copy link
Member

Fix #12197

@alexfauquette alexfauquette added the component: charts This is the name of the generic UI component, not the React module! label Feb 26, 2024
@mui-bot
Copy link

mui-bot commented Feb 26, 2024

Deploy preview: https://deploy-preview-12208--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 1469ecd

Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👌
Nitpick: Have you considered making the direction as suffix? 🤔
I.e.: ${formattedValue}-horizontal.

@alexfauquette
Copy link
Member Author

Nitpick: Have you considered making the direction as suffix? 🤔

Is their an interest? I considered the solution of adding a group <g> arround horizontal lines, and another one arround vertical lines such that keys could be the same.

But I did not considered a lot options about key naming. For me it's purely a technical aspect for React, not for dev, but I might be missing a use case

@LukasTy
Copy link
Member

LukasTy commented Feb 26, 2024

But I did not considered a lot options about key naming. For me it's purely a technical aspect for React, not for dev, but I might be missing a use case

No, I also don't have a concrete example of why going with a suffix rather than a prefix would be arguably superior.
Just a matter of preference. 👌

@alexfauquette alexfauquette merged commit db74b5e into mui:next Feb 26, 2024
18 checks passed
@alexfauquette alexfauquette deleted the fix-unique-key branch February 26, 2024 09:41
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: charts This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[charts]Unique Key property LineChart error
3 participants