[docs] Fix Pigment CSS migration content #43217
Conversation
siriwatknp
commented
Aug 7, 2024
siriwatknp
commented
- I have followed (at least) the PR section of the contributing guide.
siriwatknp
changed the title
Netlify deploy previewBundle size report |
docs/data/material/migration/migrating-to-v6/migrating-to-pigment-css.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Not directly related to this PR
Q: any particular reason to display the Next.js config in .mjs and .js and Vite only in .js?
| Next.js | Vite |
|---|---|
There was a problem hiding this comment.
Nice catch, Vite should have vite.config.ts too.
There was a problem hiding this comment.
It turns out either vite.config.mjs or vite.config.js, the content will be the same. I updated to mention the file pattern instead:
- Next, open vite config file, usually named `vite.config.js`, and add the plugin:
+ Next, open vite config file, usually named `vite.config.mjs` or `vite.config.js`, and add the plugin:There was a problem hiding this comment.
So next.config.js uses require but vite.config.js uses import?
There was a problem hiding this comment.
Yes, vite.config.js supports ESM but next.config.js requires commonjs.
docs/data/material/migration/migrating-to-v6/migrating-to-pigment-css.md
Show resolved
Hide resolved
docs/data/material/migration/migrating-to-v6/migrating-to-pigment-css.md
Outdated
Show resolved
Hide resolved
docs/data/material/migration/migrating-to-v6/migrating-to-pigment-css.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Nice. There's an open question in 4086c20#r1706823545 but I think we can move forward.
docs/data/material/migration/migrating-to-v6/migrating-to-pigment-css.md
Outdated
Show resolved
Hide resolved
…ent-css.md Co-authored-by: Sycamore <71297412+samuelsycamore@users.noreply.github.com> Signed-off-by: Siriwat K <siriwatkunaporn@gmail.com>
