Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Refine and polish out Templates page #43131

Merged
merged 15 commits into from
Aug 7, 2024
Merged

Conversation

zanivan
Copy link
Contributor

@zanivan zanivan commented Jul 31, 2024

This PR addresses some items from #41469 :
12. Rename the “landing page” template given it looks more like a home page
14. Allow to click on the image to open it. Uploading Screen Recording 2024-06-10 at 18.14.18.mov…

The changes made were:

  • Rename landing-page to marketing-page (that's why there are so many files changed)
  • Added some tweaks to templates' page text and title
  • Remove outdated files from Pricing and StickyFooter templates
  • Added a button to open template preview in the CardImage

@zanivan zanivan added docs Improvements or additions to the documentation package: material-ui Specific to @mui/material design This is about UI or UX design, please involve a designer labels Jul 31, 2024
@zanivan zanivan self-assigned this Jul 31, 2024
@zanivan zanivan changed the title [docs] Refine and polish out Template page [docs] Refine and polish out Templates page Jul 31, 2024
@mui-bot
Copy link

mui-bot commented Jul 31, 2024

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 2, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 2, 2024
@zanivan
Copy link
Contributor Author

zanivan commented Aug 2, 2024

@samuelsycamore would you mind doing a pass-through on this page content and also the templates to detect any typos or improvements?

@zanivan
Copy link
Contributor Author

zanivan commented Aug 5, 2024

@siriwatknp I think the Argos test is detecting many screenshots from the marketing page template (old landing page template). Could this be related to the new screenshot script? Otherwise, can I approve the Argos test?

@zanivan zanivan requested a review from siriwatknp August 5, 2024 14:19
@zanivan
Copy link
Contributor Author

zanivan commented Aug 6, 2024

Just a small bump on this one, I need to merge it to start working on the theme unification and consistency @siriwatknp @DiegoAndai @samuelsycamore

Copy link
Member

@samuelsycamore samuelsycamore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

text looks good to me!

Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need to revisit the regression tests for templates next. I encounter unrelated Argos changes in other PRs from templates (especially with charts) multiple times.

@zanivan zanivan merged commit c536582 into next Aug 7, 2024
28 checks passed
@zanivan zanivan deleted the template-page-polishing branch August 7, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design This is about UI or UX design, please involve a designer docs Improvements or additions to the documentation package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants