Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CP-3004] Refactored button action to accept multiple actions #2076

Merged
merged 6 commits into from
Sep 25, 2024

Conversation

mkurczewski
Copy link
Collaborator

@mkurczewski mkurczewski commented Sep 23, 2024

JIRA Reference: CP-3004

📝 Description ️

Refactored button's action property to accept an array of actions that can be executed one by one at single click.

💪 Checklist before requesting a review - nice to have

  • getState function in async thunk actions is correctly typed
  • redux selectors are used in components / prop drilling is reduce

❗ Checklist before merging a pull request

  • change went through the QA process
  • translations are updated in dedicated application
  • CHANGELOG.md is updated

Copy link
Member

@dkarski dkarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me. I just see two small things to address.

Please also ensure that it doesn’t affect the configuration coming from Kompakt or the existing e2e tests. If it does, I suggest making the necessary changes in Kompakt and updating the e2e tests as part of this PR before merging.

libs/generic-view/feature/src/lib/setup-component.tsx Outdated Show resolved Hide resolved
libs/generic-view/feature/src/lib/setup-component.tsx Outdated Show resolved Hide resolved
@mkurczewski mkurczewski changed the base branch from develop to CP-2995 September 25, 2024 09:22
@mkurczewski mkurczewski merged commit 46e2e3c into CP-2995 Sep 25, 2024
6 checks passed
@mkurczewski mkurczewski deleted the CP-3004-button branch September 25, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants