Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CP-1755] fix problem with eula modal #1097

Merged
merged 2 commits into from
Jan 24, 2023

Conversation

wojcik92michal
Copy link
Contributor

@wojcik92michal wojcik92michal commented Jan 24, 2023

Jira: CP-1755

Description
Scope:

  • eula modal now appears (see attached video)
Screenshots
Nagranie.z.ekranu.2023-01-24.o.16.17.49.mov

@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

Base: 77.80% // Head: 77.81% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (27af337) compared to base (7a7489a).
Patch coverage: 80.00% of modified lines in pull request are covered.

❗ Current head 27af337 differs from pull request most recent head 3efc366. Consider uploading reports for the commit 3efc366 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1097      +/-   ##
==========================================
+ Coverage   77.80%   77.81%   +0.01%     
==========================================
  Files         873      873              
  Lines       12368    12362       -6     
  Branches     1802     1800       -2     
==========================================
- Hits         9623     9620       -3     
+ Misses       2274     2273       -1     
+ Partials      471      469       -2     
Impacted Files Coverage Δ
packages/app/src/device/modules/device.ts 45.00% <ø> (ø)
...ackages/app/src/device/strategies/pure.strategy.ts 42.66% <0.00%> (-0.58%) ⬇️
...ges/app/src/device/actions/locked-device.action.ts 88.88% <100.00%> (-0.59%) ⬇️
...app/src/settings/services/configuration.service.ts 95.23% <0.00%> (+3.93%) ⬆️
...rc/overview/components/system/system.component.tsx 95.65% <0.00%> (+3.98%) ⬆️
...ages/app/src/overview/components/card.elements.tsx 100.00% <0.00%> (+12.50%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wojcik92michal wojcik92michal merged commit 33f07c1 into master Jan 24, 2023
@wojcik92michal wojcik92michal deleted the CP-1755-lack-of-eula-agreement branch January 24, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants