Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CP-1708] handle force sequential update process #1094

Merged
merged 4 commits into from
Jan 24, 2023

Conversation

wojcik92michal
Copy link
Contributor

@wojcik92michal wojcik92michal commented Jan 23, 2023

Jira: CP-1708

Description
Scope:

  • handling force sequential update process
  • feel free to test it
  • remove old and unused components (see 4b4f564)

Test details:

Screenshots // put images here

@wojcik92michal wojcik92michal marked this pull request as ready for review January 23, 2023 14:29
@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Base: 77.55% // Head: 77.82% // Increases project coverage by +0.27% 🎉

Coverage data is based on head (b93d351) compared to base (76c748a).
Patch coverage: 88.46% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1094      +/-   ##
==========================================
+ Coverage   77.55%   77.82%   +0.27%     
==========================================
  Files         873      873              
  Lines       12416    12362      -54     
  Branches     1807     1799       -8     
==========================================
- Hits         9629     9621       -8     
+ Misses       2319     2272      -47     
- Partials      468      469       +1     
Impacted Files Coverage Δ
packages/app/src/feature-flags/features/index.ts 100.00% <ø> (ø)
...iew-screens/helpers/use-update-flow-state.hook.tsx 100.00% <ø> (ø)
...e-device-detached/handle-device-detached.action.ts 50.00% <ø> (ø)
...ns/harmony-overview/harmony-overview.component.tsx 74.19% <62.50%> (-7.86%) ⬇️
...-screens/pure-overview/pure-overview.component.tsx 76.47% <71.42%> (-3.67%) ⬇️
...modal-flow/updating-force-modal-flow.component.tsx 87.50% <86.27%> (+7.81%) ⬆️
...onents/update-os-flow/update-os-flow.component.tsx 90.24% <100.00%> (-1.22%) ⬇️
packages/app/src/update/actions/base.action.ts 100.00% <100.00%> (ø)
...update/actions/force-update/force-update.action.ts 100.00% <100.00%> (ø)
packages/app/src/update/actions/index.ts 100.00% <100.00%> (ø)
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dkarski
Copy link
Member

dkarski commented Jan 24, 2023

feel free to test it

I tested. It's work fine ✅

  • to changes it in the development mode:
    • packages/app/src/feature-flags/features/index.ts - change Feature.ForceUpdate in Environment.Development to true

I think that the feature flag should be updated as part of this PR 😉 (for Production and AlphaProduction). Then you can easily test it as a daily build.

dkarski
dkarski previously approved these changes Jan 24, 2023
@wojcik92michal
Copy link
Contributor Author

feel free to test it

I tested. It's work fine ✅

  • to changes it in the development mode:

    • packages/app/src/feature-flags/features/index.ts - change Feature.ForceUpdate in Environment.Development to true

I think that the feature flag should be updated as part of this PR 😉 (for Production and AlphaProduction). Then you can easily test it as a daily build.

@dkarski You are right. Changed in b93d351

@wojcik92michal wojcik92michal merged commit 0f5934d into master Jan 24, 2023
@wojcik92michal wojcik92michal deleted the CP-1708-force-update-process branch January 24, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants