Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CP-1742] fixes after QA #1089

Merged
merged 5 commits into from
Jan 20, 2023
Merged

[CP-1742] fixes after QA #1089

merged 5 commits into from
Jan 20, 2023

Conversation

wojcik92michal
Copy link
Contributor

@wojcik92michal wojcik92michal commented Jan 17, 2023

Jira: CP-1742

Description
This PR cover three cases discovered by QA team:

  • displaying "checking for update failed" label (see attached image)
  • "check for update" modal may start to install update (this happen in very peculiar condition - see https://appnroll.atlassian.net/browse/CP-1742?focusedCommentId=69995 and 4th point from the comment) - see attached image
  • "silent check" now works fine for unplugging cable
Screenshots

image

image

Nagranie.z.ekranu.2023-01-18.o.08.35.27.mov

@codecov
Copy link

codecov bot commented Jan 17, 2023

Codecov Report

Base: 77.52% // Head: 77.62% // Increases project coverage by +0.09% 🎉

Coverage data is based on head (3b47dfa) compared to base (27c2631).
Patch coverage: 90.21% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1089      +/-   ##
==========================================
+ Coverage   77.52%   77.62%   +0.09%     
==========================================
  Files         867      870       +3     
  Lines       12291    12352      +61     
  Branches     1784     1794      +10     
==========================================
+ Hits         9529     9588      +59     
- Misses       2296     2298       +2     
  Partials      466      466              
Impacted Files Coverage Δ
...ailable-modal/update-available-modal.component.tsx 80.00% <57.14%> (-9.48%) ⬇️
...-screens/pure-overview/pure-overview.component.tsx 79.86% <75.00%> (+0.67%) ⬆️
...ns/harmony-overview/harmony-overview.component.tsx 81.81% <87.50%> (+0.80%) ⬆️
...ns/harmony-overview/overview-content.component.tsx 100.00% <100.00%> (ø)
...iew-screens/helpers/use-update-flow-state.hook.tsx 100.00% <100.00%> (ø)
...reens/pure-overview/overview-content.component.tsx 100.00% <100.00%> (ø)
...rc/overview/components/system-update-text/index.ts 100.00% <100.00%> (ø)
...ystem-update-text/system-update-text.component.tsx 100.00% <100.00%> (ø)
...rc/overview/components/system/system.component.tsx 95.65% <100.00%> (-0.78%) ⬇️
...onents/update-os-flow/update-os-flow.component.tsx 91.46% <100.00%> (+0.10%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wojcik92michal wojcik92michal changed the title [CP-1742] displaying checking for update failed [CP-1742] fixes after QA Jan 18, 2023
@wojcik92michal wojcik92michal marked this pull request as ready for review January 18, 2023 07:42
@wojcik92michal wojcik92michal merged commit c53016c into master Jan 20, 2023
@wojcik92michal wojcik92michal deleted the CP-1742-fixes-after-QA branch January 20, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants