Skip to content
This repository has been archived by the owner on May 4, 2024. It is now read-only.

upgrade rust toolchain 1.62.1 && edition 2021 && cargo clippy --fix #275

Merged
merged 4 commits into from
Jul 30, 2022
Merged

upgrade rust toolchain 1.62.1 && edition 2021 && cargo clippy --fix #275

merged 4 commits into from
Jul 30, 2022

Conversation

uvd
Copy link
Contributor

@uvd uvd commented Jul 18, 2022 •
edited
Loading

Motivation

upgrade rust toolchain 1.62.1 && cargo clippy --fix

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

No

@uvd uvd changed the title upgrade rust toolchain 1.62.0 && cargo clippy --fix upgrade rust toolchain 1.62.0 && edition 2021 && cargo clippy --fix Jul 18, 2022
tnowacki
tnowacki approved these changes Jul 18, 2022
View reviewed changes
Copy link
Member

@tnowacki tnowacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sblackshear
Copy link
Member

Looks like upgrading introduces some lint errors which will need to be fixed: https://github.com/move-language/move/runs/7394171716

@uvd
Copy link
Contributor Author

uvd commented Jul 19, 2022

Looks like upgrading introduces some lint errors which will need to be fixed: https://github.com/move-language/move/runs/7394171716

hello i'm fix it

@uvd uvd requested a review from tnowacki July 19, 2022 11:56
@uvd uvd changed the title upgrade rust toolchain 1.62.0 && edition 2021 && cargo clippy --fix upgrade rust toolchain 1.62.1 && edition 2021 && cargo clippy --fix Jul 20, 2022
@wrwg
Copy link
Member

wrwg commented Jul 30, 2022

This is really great, and sorry for the delay on landing! As it is now 10 days old, could we please rebase it and run again through CI? Even without merge conflicts there could be more lint errors now which people landed after @uvd did touch this last.

@uvd
Copy link
Contributor Author

uvd commented Jul 30, 2022

This is really great, and sorry for the delay on landing! As it is now 10 days old, could we please rebase it and run again through CI? Even without merge conflicts there could be more lint errors now which people landed after @uvd did touch this last.

Hey ，I'm rebase it

@wrwg wrwg merged commit 28082f5 into move-language:main Jul 30, 2022
nkysg pushed a commit to starcoinorg/move that referenced this pull request Sep 27, 2022
@uvd @nkysg
upgrade rust toolchain 1.62.1 && edition 2021 && cargo clippy --fix (m…
6710137 
…ove-language#275)

* upgrade rust toolchain 1.62.0 && cargo clippy --fix

* upgrade 2021 edition

* fix lint

* use cargo xfmt
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tnowacki tnowacki Awaiting requested review from tnowacki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@uvd @sblackshear @wrwg @tnowacki