-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cold shard eviction #219
Merged
Merged
Cold shard eviction #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is beacuse we use it in StreamingDataset init for coordinating ranks.
Also add a reference to its contained builtin SharedMemory's buf so it can be used as a drop-in replacement.
- use cache_limit argument - cache_usage int64 in shared memory - shard access times in shared memory - shard get_raw/zip/full/persistent_size - StreamingDataset._evict_shard - StreamingDataset._evict_coldest_shard - rewrite StreamingDataset._download_shard - Stream.safe_keep_zip (with local vs remote check)
dakinggg
reviewed
Apr 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For testing, would be good to have
- unit test for simple shard eviction (low cache limit)
- mosaicgpt run with shard eviction to make sure it still runs, has good throughput, loss looks fine.
Co-authored-by: Daniel King <43149077+dakinggg@users.noreply.github.com>
… queue before raising exception
karan6181
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Cold shard eviction. Keep filesystem usage under some limit. Do this by dropping least recently accessed shards as needed when downloading new shards. This is a general solution that works with random access.
MISSING
,DOWNLOADING
,PRESENT
(evicting happens under the lock)shard_states
by walking and normalizing stream local dirsStreamingDataset
keep-related args to addcache_limit
, dropkeep_raw
Issue #, if available:
Merge Checklist:
Put an
x
without space in the boxes that apply. If you are unsure about any checklist, please don't hesitate to ask. We are here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
pre-commit
on my change. (check out thepre-commit
section of prerequisites)