Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miner: refactor miner, make pending block on demand #100

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Conversation

FletcherMan
Copy link
Collaborator

@FletcherMan FletcherMan commented Jun 17, 2024

1. Purpose or design rationale of this PR

Inspired by ethereum/go-ethereum#28623.
However, we still use channel to generate work to prevent the CCC gets reset unexpectedly.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

@FletcherMan FletcherMan requested a review from a team as a code owner June 17, 2024 04:30
@FletcherMan FletcherMan added the release/0.3.x indicates that needs to be cherry-pick to release/0.3.x branch label Jun 17, 2024
@FletcherMan FletcherMan merged commit d09c25c into main Jun 17, 2024
@FletcherMan FletcherMan deleted the refactor_miner branch June 17, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/0.3.x indicates that needs to be cherry-pick to release/0.3.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants