Fixes: Don't require --rpc-login with --rpc-access-control-origins #8187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nero-project#8168 This PR removes the requirement for --rpc-login to be specified if --rpc-access-control-origins is. This will allow public nodes to serve cross-origin requests. You can still use --rpc-login with --rpc-access-control-origins, but it is no longer mandatory. Original Issue: monero-project#8168
jeffro256
changed the title
selsta
approved these changes
Feb 22, 2022
jeffro256
added a commit
to jeffro256/monero
that referenced
this pull request
Mar 25, 2022
…rigins Same as PR monero-project#8187 for release v0.17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the requirement for --rpc-login to be specified if --rpc-access-control-origins is.
This will allow public nodes to serve cross-origin requests. You can still use --rpc-login with
--rpc-access-control-origins, but it is no longer mandatory.
Original Issue: #8168