Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ReDoS vuln in mocha@5.0.2 › diff@3.3.1 #3266

Merged
merged 2 commits into from
Mar 7, 2018

Conversation

anishkny
Copy link
Contributor

@anishkny anishkny commented Mar 6, 2018

Description of the Change

  • Bump dep "diff" to 3.5.0

Alternate Designs

N/A

Why should this be in core?

diff@3.3.1 has ReDoS vuln: https://snyk.io/test/npm/mocha/5.0.2?severity=high&severity=medium&severity=low

Benefits

https://snyk.io/vuln/npm:diff:20180305

Possible Drawbacks

Applicable issues

@jsf-clabot
Copy link

jsf-clabot commented Mar 6, 2018

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@boneskull boneskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Just the one issue.

package.json Outdated
@@ -1,6 +1,6 @@
{
"name": "mocha",
"version": "5.0.2",
"version": "5.0.3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the version bump

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@boneskull boneskull added semver-patch implementation requires increase of "patch" version number; "bug fixes" area: security involving vulnerabilities labels Mar 6, 2018
@boneskull boneskull added this to the v5.0.3 milestone Mar 6, 2018
@anishkny
Copy link
Contributor Author

anishkny commented Mar 6, 2018

Reverted version bump.

@boneskull boneskull merged commit aaaa5ab into mochajs:master Mar 7, 2018
@anishkny anishkny deleted the patch-1 branch March 7, 2018 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: security involving vulnerabilities semver-patch implementation requires increase of "patch" version number; "bug fixes"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants