Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add connectivity example that demonstrates using a reaction #319

Merged
merged 2 commits into from
Nov 24, 2019
Merged

add connectivity example that demonstrates using a reaction #319

merged 2 commits into from
Nov 24, 2019

Conversation

MaikuB
Copy link
Collaborator

@MaikuB MaikuB commented Nov 23, 2019

added a new example as discussed in #316

@codecov
Copy link

codecov bot commented Nov 23, 2019 •
edited
Loading

Codecov Report

Merging #319 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #319   +/-   ##
=======================================
  Coverage   97.67%   97.67%           
=======================================
  Files          44       44           
  Lines        1631     1631           
=======================================
  Hits         1593     1593           
  Misses         38       38
Flag Coverage Δ
#flutter_mobx 94.28% <ø> (ø) ⬆️
#mobx 97.74% <ø> (ø) ⬆️
#mobx_codegen 99.75% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6216d72...1ef4aac. Read the comment docs.

pavanpodila
pavanpodila reviewed Nov 23, 2019
View reviewed changes
mobx_examples/lib/connectivity/connectivity_store.dart
@@ -0,0 +1,15 @@
import 'package:mobx/mobx.dart';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to have an example page, say examples/connectivity for mobx.pub too. What do you think?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can do though I suspect it'll be rather brief. Another issue is with the delay set to four seconds, I suspect not a lot of users will wait to see how it looks if we put a gif on there.

In any case I think that could be done in another PR. I did see that you have another PR for updating the site as well. Not sure if you plan to complete the soon or is that still in-progress?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That PR was for upgrading the Docz tool. We can do the docs in a separate PR for the example

@pavanpodila pavanpodila merged commit 4d1184b into master Nov 24, 2019
@pavanpodila pavanpodila deleted the connectivity_example branch November 24, 2019 02:10
@MaikuB MaikuB mentioned this pull request Nov 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavanpodila pavanpodila pavanpodila approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaikuB @pavanpodila