Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ColorMode setter for UI Effect #195

Closed
SlavomirDurej opened this issue Nov 11, 2019 · 2 comments
Closed

ColorMode setter for UI Effect #195

SlavomirDurej opened this issue Nov 11, 2019 · 2 comments

Comments

@SlavomirDurej
Copy link

Hello, first of all, MANY MANY thanks for your excellent work!

I've got a project that requires a runtime change of Color mode (From Multiply to Add) for the UI Effect component. Unfortunately there's no setter in the UIEffect.cs, I've tried adding :
(on line 182)
public ColorMode colorMode
{
get
{
return m_ColorMode;
}
set
{
m_ColorMode = value;
GetMaterial();
UpgradeIfNeeded();
}
}

but it did not work properly, it showed Add mode in the UI, but actually it was still multiply mode assigned...

Is there a way to do this ? At least maybe some workaround?

@mob-sakai
Copy link
Owner

Hi @SlavomirDurej

Thank you for using this plugin. :)

The current version (v3) does not support changing color mode on runtime...
It will be supported in v4. #185

@mob-sakai mob-sakai self-assigned this Nov 11, 2019
mob-sakai added a commit that referenced this issue Apr 10, 2020
This change adds the following features:
- Effects components can be added at runtime
- Effect mode, color mode, and blur mode can be changed at runtime
- No pre-production of materials required
- Support for non-default UI (TextMeshPro, SVG, Spine, etc.) in the future

Closes #202, #198, #195, #189, #173, #104

BREAKING CHANGE: Scenes, prefabs and scripts using UIEffect v3.x may not work properly.
mob-sakai added a commit that referenced this issue Apr 10, 2020
This change adds the following features:
- Effects components can be added at runtime
- Effect mode, color mode, and blur mode can be changed at runtime
- No pre-production of materials required
- Support for non-default UI (TextMeshPro, SVG, Spine, etc.) in the future

Closes #202, #198, #195, #189, #173, #104

BREAKING CHANGE: Scenes, prefabs and scripts using UIEffect v3.x may not work properly.
github-actions bot pushed a commit that referenced this issue Apr 10, 2020
# [4.0.0-preview.1](v3.2.0...v4.0.0-preview.1) (2020-04-10)

### Bug Fixes

* adjusting the brightness of the shiny shader ([29b4dad](29b4dad))
* the effect is kept even if the component is disabled (UIFlip, UIGradient) ([6124214](6124214))

### Features

* add asmdef files ([24710fc](24710fc))
* new effect that synchronize with another effect ([7a2a97c](7a2a97c)), closes [#159](#159) [#158](#158) [#143](#143)
* transfer TextMeshPro support to another package ([be90210](be90210))
* transfer UIEffectCapturedImage support to another package ([c2a2320](c2a2320))
* update docs to support Unity Package Manager ([bdc891a](bdc891a)), closes [#141](#141)
* update the effect architecture ([4c08c8c](4c08c8c)), closes [#202](#202) [#198](#198) [#195](#195) [#189](#189) [#173](#173) [#104](#104)
* update the structure of shaders ([db06e68](db06e68))
* updated the Unity version used for development to 2018.3 ([c5f22c1](c5f22c1)), closes [#169](#169)

### BREAKING CHANGES

* Scenes, prefabs and scripts using UIEffect v3.x may not work properly.
* The recommended Unity version is 2018.1 or later; it will work with Unity 2017.1, but it is not guaranteed to be supported.
* UIEffectCapturedImage will be supported by another package.
* TextMeshPro support has been removed from this package. It will be supported by another package.
github-actions bot pushed a commit that referenced this issue Apr 10, 2020
# [4.0.0-preview.1](v3.2.0...v4.0.0-preview.1) (2020-04-10)

### Bug Fixes

* adjusting the brightness of the shiny shader ([29b4dad](29b4dad))
* the effect is kept even if the component is disabled (UIFlip, UIGradient) ([6124214](6124214))

### Features

* add asmdef files ([24710fc](24710fc))
* new effect that synchronize with another effect ([7a2a97c](7a2a97c)), closes [#159](#159) [#158](#158) [#143](#143)
* transfer TextMeshPro support to another package ([be90210](be90210))
* transfer UIEffectCapturedImage support to another package ([c2a2320](c2a2320))
* update docs to support Unity Package Manager ([bdc891a](bdc891a)), closes [#141](#141)
* update the effect architecture ([4c08c8c](4c08c8c)), closes [#202](#202) [#198](#198) [#195](#195) [#189](#189) [#173](#173) [#104](#104)
* update the structure of shaders ([db06e68](db06e68))
* updated the Unity version used for development to 2018.3 ([c5f22c1](c5f22c1)), closes [#169](#169)

### BREAKING CHANGES

* Scenes, prefabs and scripts using UIEffect v3.x may not work properly.
* The recommended Unity version is 2018.1 or later; it will work with Unity 2017.1, but it is not guaranteed to be supported.
* UIEffectCapturedImage will be supported by another package.
* TextMeshPro support has been removed from this package. It will be supported by another package.
mob-sakai added a commit that referenced this issue Apr 10, 2020
Close leaked issues.
Close #198, Close #195, Close #189, Close #173, Close #104, Close #158, Close #143
github-actions bot pushed a commit that referenced this issue Apr 10, 2020
# [4.0.0-preview.2](v4.0.0-preview.1...v4.0.0-preview.2) (2020-04-10)

### Bug Fixes

* compilation fails on build ([f34ae2c](f34ae2c))
* fix project settings ([8685165](8685165)), closes [#198](#198) [#195](#195) [#189](#189) [#173](#173) [#104](#104) [#158](#158) [#143](#143)
github-actions bot pushed a commit that referenced this issue Apr 10, 2020
# [4.0.0-preview.2](v4.0.0-preview.1...v4.0.0-preview.2) (2020-04-10)

### Bug Fixes

* compilation fails on build ([f34ae2c](f34ae2c))
* fix project settings ([8685165](8685165)), closes [#198](#198) [#195](#195) [#189](#189) [#173](#173) [#104](#104) [#158](#158) [#143](#143)
@github-actions
Copy link

🎉 This issue has been resolved in version 4.0.0-preview.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

kekouyang pushed a commit to kekouyang/UIEffect that referenced this issue May 5, 2023
# [4.0.0-preview.1](mob-sakai/UIEffect@v3.2.0...v4.0.0-preview.1) (2020-04-10)

### Bug Fixes

* adjusting the brightness of the shiny shader ([29b4dad](mob-sakai@29b4dad))
* the effect is kept even if the component is disabled (UIFlip, UIGradient) ([6124214](mob-sakai@6124214))

### Features

* add asmdef files ([24710fc](mob-sakai@24710fc))
* new effect that synchronize with another effect ([7a2a97c](mob-sakai@7a2a97c)), closes [mob-sakai#159](mob-sakai#159) [mob-sakai#158](mob-sakai#158) [mob-sakai#143](mob-sakai#143)
* transfer TextMeshPro support to another package ([be90210](mob-sakai@be90210))
* transfer UIEffectCapturedImage support to another package ([c2a2320](mob-sakai@c2a2320))
* update docs to support Unity Package Manager ([bdc891a](mob-sakai@bdc891a)), closes [mob-sakai#141](mob-sakai#141)
* update the effect architecture ([4c08c8c](mob-sakai@4c08c8c)), closes [mob-sakai#202](mob-sakai#202) [mob-sakai#198](mob-sakai#198) [mob-sakai#195](mob-sakai#195) [mob-sakai#189](mob-sakai#189) [mob-sakai#173](mob-sakai#173) [mob-sakai#104](mob-sakai#104)
* update the structure of shaders ([db06e68](mob-sakai@db06e68))
* updated the Unity version used for development to 2018.3 ([c5f22c1](mob-sakai@c5f22c1)), closes [mob-sakai#169](mob-sakai#169)

### BREAKING CHANGES

* Scenes, prefabs and scripts using UIEffect v3.x may not work properly.
* The recommended Unity version is 2018.1 or later; it will work with Unity 2017.1, but it is not guaranteed to be supported.
* UIEffectCapturedImage will be supported by another package.
* TextMeshPro support has been removed from this package. It will be supported by another package.
kekouyang pushed a commit to kekouyang/UIEffect that referenced this issue May 5, 2023
AwfulDarkness0110 added a commit to AwfulDarkness0110/UIEffect that referenced this issue Jun 28, 2023
# [4.0.0-preview.1](mob-sakai/UIEffect@v3.2.0...v4.0.0-preview.1) (2020-04-10)

### Bug Fixes

* adjusting the brightness of the shiny shader ([29b4dad](mob-sakai/UIEffect@29b4dad))
* the effect is kept even if the component is disabled (UIFlip, UIGradient) ([6124214](mob-sakai/UIEffect@6124214))

### Features

* add asmdef files ([24710fc](mob-sakai/UIEffect@24710fc))
* new effect that synchronize with another effect ([7a2a97c](mob-sakai/UIEffect@7a2a97c)), closes [#159](mob-sakai/UIEffect#159) [#158](mob-sakai/UIEffect#158) [#143](mob-sakai/UIEffect#143)
* transfer TextMeshPro support to another package ([be90210](mob-sakai/UIEffect@be90210))
* transfer UIEffectCapturedImage support to another package ([c2a2320](mob-sakai/UIEffect@c2a2320))
* update docs to support Unity Package Manager ([bdc891a](mob-sakai/UIEffect@bdc891a)), closes [#141](mob-sakai/UIEffect#141)
* update the effect architecture ([4c08c8c](mob-sakai/UIEffect@4c08c8c)), closes [#202](mob-sakai/UIEffect#202) [#198](mob-sakai/UIEffect#198) [#195](mob-sakai/UIEffect#195) [#189](mob-sakai/UIEffect#189) [#173](mob-sakai/UIEffect#173) [#104](mob-sakai/UIEffect#104)
* update the structure of shaders ([db06e68](mob-sakai/UIEffect@db06e68))
* updated the Unity version used for development to 2018.3 ([c5f22c1](mob-sakai/UIEffect@c5f22c1)), closes [#169](mob-sakai/UIEffect#169)

### BREAKING CHANGES

* Scenes, prefabs and scripts using UIEffect v3.x may not work properly.
* The recommended Unity version is 2018.1 or later; it will work with Unity 2017.1, but it is not guaranteed to be supported.
* UIEffectCapturedImage will be supported by another package.
* TextMeshPro support has been removed from this package. It will be supported by another package.
AwfulDarkness0110 added a commit to AwfulDarkness0110/UIEffect that referenced this issue Jun 28, 2023
# [4.0.0-preview.2](mob-sakai/UIEffect@v4.0.0-preview.1...v4.0.0-preview.2) (2020-04-10)

### Bug Fixes

* compilation fails on build ([f34ae2c](mob-sakai/UIEffect@f34ae2c))
* fix project settings ([8685165](mob-sakai/UIEffect@8685165)), closes [#198](mob-sakai/UIEffect#198) [#195](mob-sakai/UIEffect#195) [#189](mob-sakai/UIEffect#189) [#173](mob-sakai/UIEffect#173) [#104](mob-sakai/UIEffect#104) [#158](mob-sakai/UIEffect#158) [#143](mob-sakai/UIEffect#143)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants