Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ellipse path component #10

Closed
wants to merge 2 commits into from
Closed

Add Ellipse path component #10

wants to merge 2 commits into from

Conversation

wzso
Copy link
Contributor

@wzso wzso commented Dec 13, 2023

Add Ellipse path component with test

@wzso
Copy link
Contributor Author

wzso commented Dec 13, 2023 •
edited
Loading

Oh, I missed the content provider part and documentation. Please don't merge before I finish it.

@mkj-is
Copy link
Owner

mkj-is commented Dec 13, 2023

What is the difference between this and the Oval component? I chose the name "oval" to prevent naming clashes with SwiftUI – I admit the name might not be ideal.

@wzso
Copy link
Contributor Author

wzso commented Dec 13, 2023

tbh, I didn't realise there isn't big between Ellipse and Oval, apart from the transform parameter.

@wzso wzso closed this Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wzso @mkj-is