Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] Fix expected value #50

Merged
merged 1 commit into from
Sep 18, 2024
Merged

[Tests] Fix expected value #50

merged 1 commit into from
Sep 18, 2024

Conversation

patrickvonplaten
Copy link
Contributor

@patrickvonplaten patrickvonplaten commented Sep 17, 2024

Expected values were derived from incorrect implementation. Seem to be getting values that are not fully deterministic (local vs. remote nodes) - so lowered precision for sum to 1e-1 which is at such large values still OK IMO.

cc @timlacroix

@patrickvonplaten patrickvonplaten changed the title fix tests [Tests] Fix expected value Sep 17, 2024
@timlacroix timlacroix merged commit c77d654 into main Sep 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants