Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track solanart bid purchase (Plus other various update) #20

Merged
merged 9 commits into from
Jan 5, 2022
Merged

Track solanart bid purchase (Plus other various update) #20

merged 9 commits into from
Jan 5, 2022

Conversation

kryptoj
Copy link
Collaborator

@kryptoj kryptoj commented Jan 3, 2022 •
edited
Loading

A bunch of update going into this PR:

  • Fixed buyer address tracking, previous it wasn't accurate for bidding purchase
  • Add bidding purchase tracking for solanart purchases
  • Updated discord message to show purchase via bidding (See screenshot below)
  • Updated solanart marketplace external link
    Screen Shot 2022-01-03 at 10 50 35 pm
  • Updated debug endpoint to test notification on a specific signature
    One can now preview a notification locally on a given signature and channelID
http://localhost:4000/test-sale-tx?signature=TX_SIGNATURE&channelId=DISCORD_CHANNEL_ID
e.g.
http://localhost:4000/test-sale-tx?signature=4PJ7X1ZCEj68n2HXfVx48jGnqgu9rWAxquVihpNvDizbZ5V5vUHViz2N54HHMUiBvKtx7mbmYAQ4unURg9YEgLM6&channelId=893632559001530394

@kryptoj
Add bidding purchase sale tracking for solanart
e378541 
As part of the new feature, we have to update the logic that detects
buyer address to check the token destination address instead of blindly
using the signer as the buyer. It's proven that in the case of a bidding
purchase, it's inaccurate to assume the signer is the buyer.
@kryptoj
Update purchase message to show bidding
e2626bd
@kryptoj
Fix typescript error for nonstandard owner property
c5e7937
@kryptoj
Add notify discord sale test endpoint
8f3d07d
@kryptoj
Update solana bidding sale example
953e14f
@kryptoj
Move NFTSale Data into parse function
834d78c
@kryptoj
Clean up price extraction logic
740bf70
@kryptoj kryptoj force-pushed the track-solanart-bid-purchase branch from fe65607 to 865c57e Compare January 3, 2022 12:06
@kryptoj kryptoj marked this pull request as ready for review January 4, 2022 10:16
coweatsrhubarb
coweatsrhubarb approved these changes Jan 4, 2022
View reviewed changes
Copy link
Member

@coweatsrhubarb coweatsrhubarb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just got a tiny function name suggestion. Everything LGTM, lots of good improvements 💪

src/lib/marketplaces/helper.ts Outdated Show resolved Hide resolved
@kryptoj kryptoj force-pushed the track-solanart-bid-purchase branch from c44bd2b to 16a114b Compare January 5, 2022 10:49
@kryptoj kryptoj merged commit 764e366 into main Jan 5, 2022
@kryptoj kryptoj deleted the track-solanart-bid-purchase branch January 5, 2022 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coweatsrhubarb coweatsrhubarb coweatsrhubarb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kryptoj @coweatsrhubarb